How to use WebRTC with a patch?

[mwarning]

Hi folks,

I have an app in F-Droid (Meshenger) and need WebRTC with a patch to allows connections to users via Androids own hotspot: webrtc: use own WebRTC build · meshenger-app/meshenger-android@f2a8b33 · GitHub

So I have build WebRTC as an *.aar file and added it to the repository. But the F-droid build bot does not like that: fdroid build (#7361706569) · Jobs · F-Droid / Data · GitLab (thank you linsui for notifying me)

I tried to ask on webrtc-discuss (https://groups.google.com/g/discuss-webrtc/c/pTWe0QLKNC4/m/_ulh_2NJBwAJ) to ask to upstream it. But my message does not seem to appear there…

There is also iNPUTmice/webrtc-android - Codeberg.org, it is a newer WebRTC build. But it looks like they do not want to add any patches.

So what is the approach that I need to go here?

Thank you

[mwarning]

Is it OK for f-droid if I push the WebRTC build to some public repository (e.g. Maven)?

[SkewedZeppelin]

The currently utilized WebRTC prebuilt used by F-Droid is exempted.

[mwarning]

hm, but that prebuild likely does not have the patched WebRTC that I rely on. Or can users submit patches?

[linsui]

This is OK.

[Licaon_Kter]

@SkewedZeppelin

The currently utilized WebRTC prebuilt used by F-Droid is exempted.

true kinda

@mwarning

Is it OK for f-droid if I push the WebRTC build to some public repository (e.g. Maven)?

do the steps, repo, code, etc, eg: iNPUTmice/webrtc-android - Codeberg.org

[mwarning]

@Licaon_Kter I will try to find a workaround so I do not need publish on/manage a Maven account and do not have to store a compiled library into the applications repository (what the fdroid build bot complains about) .

[Licaon_Kter]

@mwarning

I will try to find a workaround so I do not need publish on/manage a Maven account

there’s none if you NEED to use a modified webrtc lib

[mwarning]

Sorry, I fail to understand. I tried to add a webrtc*.aar file to my app repository, but the fdroid build job does not accept this (see build log in the first post). So what would have been my options?

Anyway, it seems that disabling network auto detection in WebRTC does the job. That means that I do not need to modify WebRTC.

[Licaon_Kter]

You either do all the steps to post it to maven.

Or use one of the used ones, eg. See Conversations code (uses an unmodified one) or Threema (uses a patched version) or JitsiMeet (via react-native-webrtc or whatever is that one called).

[mwarning]

OK, so when I need to have a special patch for WebRTC, then I need to push that to (e.g.) Maven for f-droid to build the application. Thank you for the clarification.